Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow usage of Material Design mdi:foo names #130

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Conversation

Habbie
Copy link
Member

@Habbie Habbie commented Oct 20, 2024

No description provided.

@Habbie
Copy link
Member Author

Habbie commented Oct 20, 2024

now we can autogenerate this file from something like ( echo '{' ; perl -pe 's/: ([0-9A-F]+)(,?)/: "$1"$2/' < scss/_variables.scss | grep '^ ' ; echo '}' ) | jq . (but I'd likely write a single Python script that goes all the way to the actual map syntax).

Would be nice to get rid of the item count that's now in both .cpp and .hpp, might be possible with something like what is done in frozen/examples/html_entities_map.cpp.

@Habbie
Copy link
Member Author

Habbie commented Nov 2, 2024

I filed Templarian/MaterialDesign-Webfont#99 to get .json instead of .scss but it's not a deal breaker :)

@Habbie Habbie changed the title WIP: allow usage of Material Design mdi:foo names allow usage of Material Design mdi:foo names Nov 9, 2024
@Habbie
Copy link
Member Author

Habbie commented Nov 9, 2024

I tried to use frozen but it needed 5GB of RAM to build the map, which is painful. Right now this PR instead constructs the map into memory, which works well, but obviously uses some RAM, which is a pity for entirely static data. The map appears to add 0.5M to the binary size, which is also a pity, but I don't have better ideas today.

@Habbie Habbie marked this pull request as ready for review November 9, 2024 23:23
@Habbie Habbie requested a review from cyclops1982 November 9, 2024 23:23
@Habbie
Copy link
Member Author

Habbie commented Nov 9, 2024

ready for review. tested on toon1.

Copy link
Collaborator

@cyclops1982 cyclops1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me!
Tested with dashboard and normal entities on -lvgl. Good to merge imho!

@Habbie Habbie merged commit ead0075 into voorkant:main Nov 10, 2024
4 checks passed
@Habbie Habbie deleted the mdi-names branch November 10, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants